refactor: move web folder to web/client #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bc86d59 in 2 minutes and 4 seconds
More details
- Looked at
1529lines of code in144files - Skipped
8files when reviewing. - Skipped posting
30drafted comments based on config settings.
1. bun.lock:108
- Draft comment:
PR title suggests a folder move, but the issue requests better onboarding docs for Next.js, Remix, Webpack, and Babel. No documentation updates are present. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. bun.lock:8
- Draft comment:
New dependency for 'apps/backend' is added while the '@onlook/web' block is removed. Ensure that all references to the moved web folder have been updated consistently. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to ensure that all references to a moved folder have been updated consistently. This falls under the rule of not asking the author to double-check things. The comment does not provide a specific suggestion or point out a specific issue, making it unapproved.
3. bun.lock:8
- Draft comment:
Added the new 'apps/backend' block. Please verify that the workspace/package.json configuration is updated accordingly so that this new module is correctly recognized. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to verify that a configuration file is updated accordingly. This falls under the rule of not asking the author to double-check things or ensure behavior is intended. Therefore, this comment should be removed.
4. bun.lock:108
- Draft comment:
The entire 'apps/web' block has been removed. Since the PR title indicates the web folder is moved to 'web/client', please ensure that the new location is correctly registered in your workspace configuration and reflected in the lock file. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. bun.lock:684
- Draft comment:
The reference to '@onlook/web' (workspace:apps/web) has been removed. Confirm that the web client now in 'web/client' is properly updated in all workspace references. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. README.md:1
- Draft comment:
Issue 123 requires improved onboarding documentation (including docs for Next.js, Remix, Webpack, Babel), but no documentation updates are observed in the diff. Please add the required docs to fully resolve the issue. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. bun.lock:1122
- Draft comment:
There is an apparent update for 'agent-base' from version 6.0.2 to 7.1.3 here, yet elsewhere some dependencies still reference [email protected]. Verify that all packages get a consistent version to avoid compatibility issues. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. apps/web/client/README.md:9
- Draft comment:
Typographical/clarity issue: The phrase 'if you still are in the wind' on line 9 seems unclear or may be a typo. Consider revising it to something more conventional like 'if you are still unsure' or 'if you're still confused'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. apps/web/client/src/app/layout.tsx:38
- Draft comment:
In line 38, consider removing the extra space in the closing tag to ensure consistency. It should be . - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. apps/web/client/src/app/project/[id]/_components/canvas/frame/web-frame.tsx:13
- Draft comment:
Typo: In the commented-out code on line 13, consider changingshouldShowDomFailedtoshouldShowDOMFailedfor clarity and consistency with standard acronym formatting. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
11. apps/web/client/src/app/project/[id]/_components/canvas/index.tsx:47
- Draft comment:
Typographical error: The variable 'lintedScale' on line 47 (and its usage on line 52 and line 57) appears to be a typo. Consider renaming it to 'clampedScale' for clarity and consistency with the clampZoom function. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
12. apps/web/client/src/app/project/[id]/_components/canvas/overlay/pan.tsx:43
- Draft comment:
In the className string on line 43, there's a trailing space ('visible ') which may be unintentional. It would be cleaner to remove the extra space to avoid any potential issues with style matching. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. apps/web/client/src/app/project/[id]/_components/right-panel/chat/panel-dropdown.tsx:75
- Draft comment:
Typographical: In the dropdown item label at line 75, 'Auto - apply results' contains spaces around the hyphen. Consider using 'Auto-apply results' for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
14. apps/web/client/src/app/project/[id]/_components/right-panel/index.tsx:125
- Draft comment:
Typographical issue: The JSX element on this line starts with an unnecessary space between '<' and 'TabsTrigger'. Please remove the extra space for consistency and to follow standard JSX syntax. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
15. apps/web/client/src/app/project/[id]/_components/right-panel/index.tsx:148
- Draft comment:
Typographical issue: The JSX element on this line starts with an unnecessary space between '<' and 'TabsContent'. Please remove the extra space for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
16. apps/web/client/src/app/project/[id]/_components/right-panel/index.tsx:152
- Draft comment:
Typographical issue: The JSX element on this line starts with an unnecessary space between '<' and 'TabsContent'. Please remove the extra space for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
17. apps/web/client/src/app/project/[id]/page.tsx:30
- Draft comment:
Consider adding spaces in the calc expression for better clarity and consistency. For example, changecalc(100%-2.60rem)tocalc(100% - 2.6rem). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
18. apps/web/client/src/components/hotkey.ts:23
- Draft comment:
Consider changing 'Open Devtool' to 'Open DevTools' for consistency and proper presentation. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
19. apps/web/client/src/components/hotkey.ts:24
- Draft comment:
For consistency, consider capitalizing 'chat' as 'Chat' in 'Add to AI chat' to match 'New AI Chat'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
20. apps/web/client/src/components/store/editor/engine/ast/index.ts:177
- Draft comment:
Typo: The console warning message on line 177 says 'Failed to getNodeFromDomId: Document not found', but the function is named getElementFromDomId. Consider updating the warning to 'Failed to getElementFromDomId: Document not found' for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
21. apps/web/client/src/components/store/editor/engine/overlay/utils.ts:83
- Draft comment:
In the comment for the function 'getRelativeMousePositionToWebview', it says 'Get the relative mouse position a webview element inside the canvas container.' It might be clearer to include the word 'of' (e.g., 'Get the relative mouse position of a webview element inside the canvas container.') for improved readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
22. apps/web/client/src/components/store/editor/engine/theme/index.ts:3
- Draft comment:
Typographical Issue: The import statement on line 3 references 'ColorPalletGroup'. If this is meant to pertain to a color palette, consider renaming it to 'ColorPaletteGroup' for clarity and correctness. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
23. apps/web/client/src/components/store/editor/eventHandler.ts:33
- Draft comment:
Typographical error: In handleDomProcessed, the error message 'No args found for dom ready event' should be updated to 'No args found for dom processed event' for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
24. apps/web/client/src/components/store/editor/eventHandler.ts:103
- Draft comment:
Typographical error: In handleElementRemoved, the error message 'No args found for move element event' is misleading. It should refer to the element removal event (e.g., 'No args found for remove element event'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
25. apps/web/client/src/components/store/editor/eventHandler.ts:117
- Draft comment:
Typographical error: In handleElementTextEdited, the error message 'No args found for move element event' should be updated to accurately reflect the context (for instance, 'No args found for element text edited event'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
26. apps/web/client/src/components/store/editor/eventHandler.ts:148
- Draft comment:
Typographical error: In handleElementGrouped, the error message 'No args found for move element event' should be revised to reflect the grouping context (e.g., 'No args found for element grouped event'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
27. apps/web/client/src/components/store/editor/eventHandler.ts:163
- Draft comment:
Typographical error: In handleElementUngrouped, the error message 'No args found for move element event' should be changed to accurately represent the ungrouping event (e.g., 'No args found for element ungrouped event'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
28. apps/web/client/src/components/store/editor/styles/tag.ts:26
- Draft comment:
For the descriptions of the heading tags (h1 through h6), the sentence starts with 'Represent six levels of section headings.' Consider changing 'Represent' to 'Represents' for grammatical consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
29. apps/web/client/src/components/store/editor/styles/tag.ts:71
- Draft comment:
In the description for the 'a' tag, there's an extra tab character between '' and the following text. Consider replacing it with a regular space to ensure consistent spacing. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
30. apps/web/client/src/components/store/editor/styles/tag.ts:218
- Draft comment:
In the 'figure' tag description, the caption element is referred to as '(figcaption) element'. For clarity and consistency with HTML notation, consider changing it to ' element'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_qIjp3vlXa4LZ4v0G
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c791001 in 57 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. package.json:16
- Draft comment:
Ensure the new workspace ('apps/web/client') is reflected in all relevant configs. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. package.json:12
- Draft comment:
The PR description mentions adding onboarding docs, but the only change is a folder refactor. Confirm that the issue is fully resolved. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment asks the PR author to confirm that the issue is fully resolved, which violates the rule against asking for confirmation or ensuring behavior is intended. It does not provide a specific code suggestion or ask for a specific test to be written.
3. package.json:12
- Draft comment:
Ensure that moving 'web' to 'web/client' is propagated everywhere. Verify that any tooling or script references to the old location are updated. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure that changes are propagated and to verify updates, which violates the rule against asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue.
4. package.json:12
- Draft comment:
The PR description and referenced issue mention adding framework documentation for better onboarding. This diff only moves the workspace folder. Confirm that the docs updates are included or planned in subsequent commits. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to confirm their intention regarding documentation updates, which violates the rule against asking for confirmation or updates to the PR description. It does not provide a specific code suggestion or request for tests.
Workflow ID: wflow_YMgwbBHeyBjR0TTd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1731108 in 1 minute and 55 seconds
More details
- Looked at
831lines of code in1files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. bun.lock:120
- Draft comment:
Verify that the new package block for 'apps/web/client' is correctly configured and that corresponding package.json changes (if any) are in sync. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to verify the configuration and ensure synchronization, which violates the rule against asking for confirmation or verification. It doesn't provide a specific suggestion or point out a specific issue.
2. bun.lock:240
- Draft comment:
The issue mentions adding better onboarding docs for frameworks (Next.js, Remix, etc.), but this PR only refactors the folder structure. Ensure that the documentation updates are included to fully resolve the issue. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. bun.lock:700
- Draft comment:
New workspace reference '@onlook/web' added here. Please confirm that moving the web folder to 'apps/web/client' is correctly reflected in the workspace configuration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to confirm that a change is correctly reflected in the workspace configuration. This falls under asking the author to confirm their intention or to double-check things, which is against the rules.
4. bun.lock:1150
- Draft comment:
The lock file now includes an entry for Next.js at version 15.2.4. Please verify that this version (and its dependency tree) is intentional and compatible with your project requirements. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. bun.lock:1500
- Draft comment:
The lock file now locks React and React-DOM at version 19.1.0 for '@onlook/web'. This is a significant jump compared to widely adopted React 18.x. Confirm that this upgrade is intended and that all related packages and documentation remain compatible. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. bun.lock:1
- Draft comment:
This lock file update includes a large number of dependency entries and version/hash changes. Ensure that these changes were generated intentionally (e.g. via a fresh install) and that no unintended dependency bumps have been introduced that might affect production stability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. bun.lock:1
- Draft comment:
The PR description mentions enhancements to onboarding documentation (Next.js, Remix, Webpack, and Babel), but the current diff only shows changes to the lock file. Please ensure that the relevant documentation files are updated to cover these framework guides. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_3OHYZuXP8C87VjkD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
* Move web folder to web/client * Update monorepo * update lock file
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
* Move web folder to web/client * Update monorepo * update lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Refactor to move
apps/webtoapps/web/clientand update related paths and dependencies.apps/webtoapps/web/client, affecting multiple files including.env.example,README.md, andsrc/app/_components/main.tsx.package.jsonto includeapps/web/clientin workspaces.bun.lockto reflect new pathapps/web/client.@tanstack/query-core,@tanstack/react-query, and@unrs/resolver-binding-*packages.This description was created by
for 1731108. It will automatically update as commits are pushed.