Skip to content

feat: dimension label next to selection #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

Pulkitxm
Copy link
Contributor

@Pulkitxm Pulkitxm commented Aug 31, 2024

Description

This pull request addresses the alignment issue(#97) of the text within the red background rectangle in the SVG rendering. The adjustments ensure that the text is correctly centered both horizontally and vertically within the rectangle.

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

Screenshot

image

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, I moved the function into just the ClickRect for simplifying the API.
Great job on the label!

@Kitenite Kitenite merged commit 99929c9 into onlook-dev:main Aug 31, 2024
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants