Disable half2 for ExLlama when using HIP #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using kernels that rely on half2 produce gibberish output when using ROCm. ExLlama UI also disable half2 in the same way when using HIP.
|
Thanks for your great work, I can confirm this works wonderfully. One thing: |
|
Thank you for the extremely quick fix, I can also confirm it works as expected now. |
|
I've just tried this fix and it works. Man, you deserve all the love of the universe. Can't thank you enough! |
jdehorty
pushed a commit
to jdehorty/text-generation-webui
that referenced
this pull request
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using kernels that rely on half2 produce gibberish output when using ROCm. ExLlama UI also disable half2 in the same way when using HIP.
Fix #2840