Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running the ruler benchmark (
pencompass/configs/datasets/ruler/ruler_16k_gen.py
) raised a model engine error related to the usage ofos.environ.get(...)
. The traceback is as follows:This error affects all
ruler_<number>k_gen.py
.Modification
To resolve this, I replaced
os.environ.get(...)
withos.environ.build().get(...)
, which I have used successfully in similar model engine contexts. An alternative is to use the{{$ENV_NAME:value}}
syntax, but this tends to introduce additional complexity and potential errors.Checklist
Before PR:
After PR: