v5.0.x: Fix for code scanning alerts 1-7, 12, 17-19, 21-22 #13595
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit permissions into GitHub action workflows, as suggested by Copilot. Ported to v5.0.x branch from main commit b15a17b. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit b15a17b)
jsquyres
requested review from
Copilot and
devreal
and removed request for
devreal
There was a problem hiding this comment.
Pull request overview
This PR adds explicit permissions to GitHub Actions workflows to address code scanning security alerts. The changes implement the principle of least privilege by restricting workflow permissions to read-only access to repository contents, following GitHub Actions security best practices.
Key Changes:
- Added
permissions: contents: readto six workflow files - Consistent placement of permissions block after the
on:trigger definition - Cherry-picked from main branch commit b15a17b
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ompi_nvidia.yaml |
Added read-only contents permission to NVIDIA CI workflow |
.github/workflows/ompi_mpi4py_tests.yaml |
Added read-only contents permission to reusable mpi4py tests workflow |
.github/workflows/ompi_mpi4py.yaml |
Added read-only contents permission to mpi4py build and test workflow |
.github/workflows/macos-checks.yaml |
Added read-only contents permission to macOS build and test workflow |
.github/workflows/compile-rocm.yaml |
Added read-only contents permission to ROCM compilation workflow |
.github/workflows/compile-cuda.yaml |
Added read-only contents permission to CUDA compilation workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit permissions into GitHub action workflows, as suggested by Copilot.
Ported to v5.0.x branch from main commit b15a17b.
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit b15a17b)