Intel simulator build error: BC is defined twice

[antonioleal]

Got this one when building with GCC11

Running internal register sanity checks on B5500 simulator.
*** Good Registers in B5500 simulator.
gcc -std=gnu99 -U__STRICT_ANSI__ -O2 -DNDEBUG=1 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -DSIM_COMPILER="GCC Version: 11.2.0" -DSIM_BUILD_TOOL=simh-makefile -I . -Werror -D_GNU_SOURCE -DHAVE_PCRE_H -DHAVE_SEMAPHORE -DHAVE_SYS_IOCTL -DHAVE_LINUX_CDROM -DSIM_HAVE_DLOPEN=so -DHAVE_EDITLINE -DHAVE_UTIME -DHAVE_LIBPNG -DHAVE_ZLIB -DHAVE_GLOB -DHAVE_SHM_OPEN ./Intel-Systems/common/i8080.c ./Intel-Systems/Intel-MDS/imds_sys.c ./Intel-Systems/common/i3214.c ./Intel-Systems/common/i8251.c ./Intel-Systems/common/i8253.c ./Intel-Systems/common/i8255.c ./Intel-Systems/common/i8259.c ./Intel-Systems/common/ieprom.c ./Intel-Systems/common/ioc-cont.c ./Intel-Systems/common/ipc-cont.c ./Intel-Systems/common/iram8.c ./Intel-Systems/common/isbc064.c ./Intel-Systems/common/isbc202.c ./Intel-Systems/common/isbc201.c ./Intel-Systems/common/isbc206.c ./Intel-Systems/common/isbc464.c ./Intel-Systems/common/isbc208.c ./Intel-Systems/common/port.c ./Intel-Systems/common/irq.c ./Intel-Systems/common/multibus.c ./Intel-Systems/common/mem.c ./Intel-Systems/common/sys.c ./Intel-Systems/common/zx200a.c ./scp.c ./sim_console.c ./sim_fio.c ./sim_timer.c ./sim_sock.c ./sim_tmxr.c ./sim_ether.c ./sim_tape.c ./sim_disk.c ./sim_serial.c ./sim_video.c ./sim_imd.c ./sim_card.c -I ./Intel-Systems/Intel-MDS -o BIN/intel-mds -lm -lrt -lpthread -lpcre -ldl -ledit -ltermcap -lpng -lz -lvdeplug -Wl,-R,/usr/lib64/ -L/usr/lib64/
./Intel-Systems/common/isbc208.c:441: error: "BC" redefined [-Werror]
441 | #define BC 0x02 /* Bad cylinder */
|
In file included from ./Intel-Systems/common/isbc208.c:398:
./Intel-Systems/Intel-MDS/system_defs.h:36: note: this is the location of the previous definition
36 | #define BC BC_Global
|
cc1: all warnings being treated as errors
make: *** [makefile:2756: BIN/intel-mds] Error 1

[bwenrich]

I am encountering the similar issue - b5500 succeeds but intel-mds fails on the Intel common files. This seems to be related to changes in #460 but I'm not clear what the solution might be (renaming something, conditional defines, etc).

gcc -std=gnu99 -U__STRICT_ANSI__  -O2 -DNDEBUG=1 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -DSIM_GIT_COMMIT_ID=29d390024fa994947aa65b1b65eb60e106de0388 -DSIM_GIT_COMMIT_TIME=2025-04-25T10:28:28-0700  -DSIM_COMPILER="GCC Version: 15.1.1" -DSIM_BUILD_TOOL=simh-makefile -I . -Werror 
-D_GNU_SOURCE -DHAVE_PCRE_H -DHAVE_SEMAPHORE -DHAVE_SYS_IOCTL -DHAVE_LINUX_CDROM -DSIM_HAVE_DLOPEN=so -DHAVE_EDITLINE -DHAVE_UTIME -DHAVE_LIBPNG -DHAVE_ZLIB -DHAVE_GLOB -DHAVE_SHM_OPEN  
./Intel-Systems/common/i8080.c ./Intel-Systems/Intel-MDS/imds_sys.c ./Intel-Systems/common/i3214.c ./Intel-Systems/common/i8251.c ./Intel-Systems/common/i8253.c ./Intel-Systems/common/i8255.c ./Intel-Systems/common/i8259.c ./Intel-Systems/common/ieprom.c ./Intel-Systems/common/ioc-cont.c ./Intel-Systems/common/ipc-cont.c ./Intel-Systems/common/iram8.c ./Intel-Systems/common/isbc064.c ./Intel-Systems/common/isbc202.c ./Intel-Systems/common/isbc201.c 
./Intel-Systems/common/isbc206.c ./Intel-Systems/common/isbc464.c ./Intel-Systems/common/isbc208.c ./Intel-Systems/common/port.c ./Intel-Systems/common/irq.c ./Intel-Systems/common/multibus.c ./Intel-Systems/common/mem.c ./Intel-Systems/common/sys.c ./Intel-Systems/common/zx200a.c 
./scp.c ./sim_console.c ./sim_fio.c ./sim_timer.c ./sim_sock.c ./sim_tmxr.c ./sim_ether.c ./sim_tape.c ./sim_disk.c ./sim_serial.c ./sim_video.c ./sim_imd.c ./sim_card.c -I ./Intel-Systems/Intel-MDS -o BIN/intel-mds -lm -lrt -lpthread -lpcre -ldl -ledit -ltermcap -lpng -lz
./Intel-Systems/common/isbc208.c:441:9: error: ‘BC’ redefined [-Werror]
  441 | #define BC              0x02            /* Bad cylinder */
      |         ^~
In file included from ./Intel-Systems/common/isbc208.c:398:
./Intel-Systems/Intel-MDS/system_defs.h:36:9: note: this is the location of the previous definition
   36 | #define BC BC_Global
      |         ^~
cc1: all warnings being treated as errors
make: *** [makefile:2756: BIN/intel-mds] Error 1

The same thing is happening in multiple environments:

• Debian 12 w/ GCC 12.2.0
• Fedora 42 w/ GCC 15.1.1
• Ubuntu 24.04 w/ GCC 13.3.0
  All of these are Podman containers. Not tested in Alpine as my build env has been broken for some time due to other problems.

[antonioleal]

...well, commenting out the 3 #define lines in commit in 2e0d51e does allow the at least the simulator to build:

in /Intel-Systems/Intel-MDS/system_defs.h

/* Rename of global PC, BC and SP variables to avoid namespace conflicts on some platforms */
//#define PC PC_Global
//#define BC BC_Global
//#define SP SP_Global

[hbent]

Yeah, 2e0d51e is an awful hack. These variables need to actually be renamed in the appropriate source files. I can put together a patch but I think there's a larger issue here. Using two and three letter #defines in general seems like asking for trouble.

[jbglaw]

I trapped into this as well. Broke the intel-mds build only for me.