macOS-12 CI/CD failure fix, periodic CMake regenerate#398
macOS-12 CI/CD failure fix, periodic CMake regenerate#398pkoning2 merged 2 commits intoopen-simh:masterfrom
Conversation
Zlib is no longer packaged as part of macOS, now needs to be installed by HomeBrew.
- Periodic "python cmake/generate.py" to sync with makefile changes. - Ensure that AIO_CCDEFS (makefile) and USES_AIO (CMake generate.py) are present for PDP-10 simulators. Otherwise, user gets a warning message when the simulator starts about network support and asynchronous I/O.
|
@bscottm Nice way to slip in your previously discussed and still open cross thread interference changes. See discussion details in that original PR. |
|
@markpizz: ??? No clue what you're talking about. |
Well, I got a email with these contents:
I opened a browser to github.com/open-simh/simh and selected this PR in the Pull Requests and composed my comment. Ahh, I now see that the subject on the above message was actually due to you had pushing the changes in this PR to your prior PR. Sorry for any confusion. I'm not sure you should be mixing commits between different PRs though... |
|
@markpizz: There are only two commits here, both related to the build system (makefile and CMake). There's nothing from my scp-async-check branch. You may have seen activity on my other branches when I updated my repo to sync with open-simh/master on several branches. |
|
Nice work. |
4 participants
zlib now needs to be an explicit HomeBrew dependency. Previously, Apple distributed zlib as part of macOS. That is no longer the case.
CMake: Periodic
generate.pyto update simulatorCMakeLists.txtbuild files.PDP-10: Not entirely clear to me how/when
AIO_CCFLAGSwent missing (which causesgenerate.pyto addUSES_AIOto the CMakeadd_simulatorarguments. Without AIO, the PDP-10 simulator users get a warning message with respect to AIO and networking.