IMLAC: Type consistency warnings.#430
Conversation
| @@ -1,9 +1,9 @@ | |||
| # Attach to a server. If the remote port isn't telnet, append ;notelnet. | |||
| attach tty 12345,connect=localhost:23 | |||
| attach tty 12345,connect=192.168.50.248:23 | |||
There was a problem hiding this comment.
Please remove this change.
| set rom type=stty | ||
| # Load SSV version 22. | ||
| load -s ssv22.iml | ||
| load -s %~p0/ssv22.iml |
There was a problem hiding this comment.
Please remove this change.
| if (ON) | ||
| if (ON) { | ||
| sim_activate_after (&dp_unit, 2); | ||
| } |
There was a problem hiding this comment.
Please remove this change.
|
|
||
| static uint16 | ||
| irq_iot (uint16 insn, uint16 AC) | ||
| irq_iot (uint16 insn, uint16 CUR_AC) |
There was a problem hiding this comment.
Please remove these changes.
There was a problem hiding this comment.
Shadows AC -- is shadowing AC intentional?
There was a problem hiding this comment.
Yes. The global AC should not be used inside this function.
larsbrinkhoff
left a comment
larsbrinkhoff
left a comment
There was a problem hiding this comment.
I'm the original author of the Imlac simulator. I suggest some changes to be made to this pull request.
|
@larsbrinkhoff given the set of revisions to the original change, why not merely consider what's left of the original changes as a "suggestion" and submit a new PR which is exactly what you want, with comments referring to the original suggestion if you want. |
|
@markpizz I think updating this pull request should suffice. History rewriting and a force push will do this. |
|
I pushed the individual change sets so that it is clear what was done. Paul can squash the individual commits into one big comment when the PR is merged. |
larsbrinkhoff
left a comment
larsbrinkhoff
left a comment
There was a problem hiding this comment.
Looks good now. Thanks!
|
@larsbrinkhoff: Fewer warnings declutters the build output. Appreciate you indulging my changes. |
|
Maintainers, @pkoning2 et al, I recommend squash merging these commits. |
|
As the original author of the IMLAC emulator, I reviewed and approved this. |
4 participants
No description provided.