CMAKE: Remove CPACK_BUILD_CONFIG from package name#537
CMAKE: Remove CPACK_BUILD_CONFIG from package name#537LegalizeAdulthood wants to merge 1 commit intoopen-simh:masterfrom
Conversation
LegalizeAdulthood
force-pushed
the
legalize-CPACK_BUILD_CONFIG
branch
from
350b765 to
d4c472e
Compare
|
Committed on my ZIMH hard fork in pmetzger/zimh@fd0fc004 |
|
Apparently this is undocumented as mentioned here, but if you specify So perhaps a "better" change would be to only append the value of this variable to the list if it is non-empty. When I was building packages, because I didn't run CPack manually with |
|
I'll update my PR to append the variable only if non-empty. |
|
I dunno. I think it's not a great idea to rely on undocumented CPack behavior? Makes me pretty uncomfortable. |
|
Since I didn't contribute the entirety of the CMake build scripts, I'm trying to make changes consistent with the original intent. |
LegalizeAdulthood
force-pushed
the
legalize-CPACK_BUILD_CONFIG
branch
2 times, most recently
from
2ca5d42 to
6853cac
Compare
This is an undocumented variable that will hold the build configuration, e.g. Debug, Release, etc., used to create a package with CPack. It is only set if you provide an explicit configuration argument to CPack.
LegalizeAdulthood
force-pushed
the
legalize-CPACK_BUILD_CONFIG
branch
from
6853cac to
d927e2b
Compare
LegalizeAdulthood
changed the title
2 participants
This isn't a predefined CMake or CPack variabe and isn't set anywhere in the CMake scripts.