Handle macOS target triplet#538
Merged
pkoning2 merged 2 commits intoopen-simh:masterfrom May 2, 2026
Merged
Conversation
LegalizeAdulthood
force-pushed
the
legalize-macos-triplet
branch
from
41ef82d to
63d788f
Compare
pmetzger
reviewed
Apr 16, 2026
|
|
||
| set (SIMH_VCPKG_PLATFORM "linux") | ||
| elseif (CMAKE_SYSTEM_NAME STREQUAL "Darwin") | ||
| set(SIMH_VCPKG_PLATFORM "osx") |
There was a problem hiding this comment.
Shouldn't this now be macos or some such?
|
Honest question (not being negative): what does adding this improve in the current build process? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and when the triplet couldn't be determined, include some diagnostic info to help you figure out why it failed.