[exporter/clickhouse] Unexport extra Config methods - #33647
Merged
codeboten merged 1 commit intoJun 19, 2024
Conversation
We need to keep the public Go API lean and don't export API when it's not required
dmitryax
force-pushed
the
clickhouse-remove-exposed-api
branch
from
June 19, 2024 05:29
616f671 to
0620b5c
Compare
SpencerTorres
approved these changes
Jun 19, 2024
SpencerTorres
left a comment
SpencerTorres
left a comment
Member
There was a problem hiding this comment.
Looks like this covers everything from the recent PRs. Thanks!
codeboten
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to keep the public Go API lean and don't export API when it's not required