[load-generator] Split trace grouping based on workflow context - #2321
Merged
Conversation
Signed-off-by: Shenoy Pratik <pshenoy36@gmail.com>
Signed-off-by: Shenoy Pratik <pshenoy36@gmail.com>
ps48
marked this pull request as ready for review
June 30, 2025 17:40
julianocosta89
approved these changes
Jul 1, 2025
Member
|
Thx @ps48 ! |
rnjn
pushed a commit
to base-14/opentelemetry-demo
that referenced
this pull request
Jul 28, 2025
…-telemetry#2321) * [load-genrator] Split trace grouping based on workflow context Signed-off-by: Shenoy Pratik <pshenoy36@gmail.com> * update changelog Signed-off-by: Shenoy Pratik <pshenoy36@gmail.com> --------- Signed-off-by: Shenoy Pratik <pshenoy36@gmail.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR: #2265 introduced trace context in logs. The PR resulted in
user_add_to_cart(and any internal spans) inheriting the same trace context as the top-level spanuser_checkout_multi. Over time, all tasks executed by the user session are part of one large trace. This can lead to trace explosion or even semantics being lost.This is a follow up fix based on comment: #2265 (comment)
Related issue: #2250
Before:
After:
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.