Implement traceID-ratio and parent-based samplers in eBPF - #1150
Merged
Conversation
RonFed
changed the title
RonFed
marked this pull request as ready for review
October 5, 2024 14:25
MrAlias
reviewed
Oct 10, 2024
MrAlias
approved these changes
Oct 10, 2024
MrAlias
left a comment
MrAlias
left a comment
Contributor
There was a problem hiding this comment.
Outside of the Makefile question, this looks good to go.
MrAlias
reviewed
Oct 15, 2024
…t.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the eBPF side of basic samplers implementation:
traceIDRatio,ParentBased,AlwaysOnandAlwasyOff.Basic testing I did with the
httpPlusDbexample:I used a test script that calls the endpoint of the application 1000 times.
Using
OTEL_TRACES_SAMPLER=always_onUsing
OTEL_TRACES_SAMPLER=parentbased_traceidratio, OTEL_TRACES_SAMPLER_ARG=0.1Using
OTEL_TRACES_SAMPLER=parentbased_traceidratio, OTEL_TRACES_SAMPLER_ARG=0.01Split from #971
Part of #953