Skip to content

Add test for logging from a span in the opentracing bridge #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tongoss
Copy link
Contributor

@tongoss tongoss commented Jun 21, 2025

Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.0%. Comparing base (787518f) to head (662d858).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6919   +/-   ##
=====================================
  Coverage   82.9%   83.0%           
=====================================
  Files        261     261           
  Lines      24256   24256           
=====================================
+ Hits       20130   20141   +11     
+ Misses      3751    3740   -11     
  Partials     375     375           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 22, 2025
@dmathieu
Copy link
Member

With #6916 being merged, you can't use the internal module anymore and need to use local private methods.

@tongoss
Copy link
Contributor Author

tongoss commented Jun 23, 2025

With #6916 being merged, you can't use the internal module anymore and need to use local private methods.

@dmathieu , I have updated the testing cases accordingly.

@dmathieu dmathieu merged commit a365d85 into open-telemetry:main Jun 23, 2025
33 checks passed
@pellared pellared added this to the v1.37.0 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants