add config model customizer #7118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7118 +/- ##
============================================
+ Coverage 89.93% 89.97% +0.03%
- Complexity 6676 6689 +13
============================================
Files 750 751 +1
Lines 20168 20187 +19
Branches 1978 1982 +4
============================================
+ Hits 18138 18163 +25
+ Misses 1435 1432 -3
+ Partials 595 592 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
reviewed
Feb 24, 2025
...ry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationModelCustomizerProvider.java
Outdated
Show resolved
Hide resolved
…tension/incubator/fileconfig/OpenTelemetryConfigurationModelCustomizerProvider.java Co-authored-by: jack-berg <[email protected]>
zeitlinger
force-pushed
the
add-config-mode-customizer
branch
from
0700275 to
5fd3e48
Compare
|
@jack-berg the only failing check is transient - PR can be reviewed 😄 |
jack-berg
approved these changes
Mar 19, 2025
.../io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationCustomizer.java
Show resolved
Hide resolved
.../io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationCreateTest.java
Outdated
Show resolved
Hide resolved
| Function<? super I, ? extends O1> first, Function<? super O1, ? extends O2> second) { | ||
| return (I configured) -> { | ||
| O1 firstResult = first.apply(configured); | ||
| return second.apply(firstResult); |
There was a problem hiding this comment.
In the future, we might consider adding opt-in logging to print the out change in the model after each stage of customization, but I'm happy to come back to that type of thing later. This is a good start!
There was a problem hiding this comment.
let's leave that as a next step then
jack-berg
reviewed
Mar 21, 2025
| * configuration. | ||
| * | ||
| * @param customizer the customizer to add | ||
| */ | ||
| void addModelCustomizer( | ||
| Function<OpenTelemetryConfigurationModel, OpenTelemetryConfigurationModel> customizer); |
There was a problem hiding this comment.
Just realizing that this is going to be a problematic contract from a packaging standpoint..
- Currently, the SPI lives in
opentelemetry-sdk-extension-incubator - In the future, we'll want to move it to
opentelemetry-sdk-extension-autoconfigure-spiwith the rest of the SPIs - That leaves a thorny question for where
OpenTelemetryConfigurationModeland the rest of the data model lives. First guess would beopentelemetry-sdk-extension-autoconfigure, but that creates a dependency cycle. They could live inopentelemetry-sdk-extension-autoconfigure-spi, oropentelemetry-sdk, oropentelemetry-sdk-common, or some newopentelemetry-sdk-configpackage.
Idk, let's cross that bridge when we get there.
jack-berg
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates open-telemetry/opentelemetry-specification#4416
Adds a hook for distributions to customize the parsed configuration.