Skip to content

Remove obsolete SdkMeterProviderUtil#setCardinalitylimit API #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jack-berg
Copy link
Member

This API was promoted to the stable API in 1.44.0 but I forgot to remove the experimental method for setting:

/**
* Set the cardinality limit.
*
* <p>Read {@link MemoryMode} to understand the memory usage behavior of reaching cardinality
* limit.
*
* @param cardinalityLimit the maximum number of series for a metric
* @since 1.44.0
*/
public ViewBuilder setCardinalityLimit(int cardinalityLimit) {
if (cardinalityLimit <= 0) {
throw new IllegalArgumentException("cardinalityLimit must be > 0");
}
this.cardinalityLimit = cardinalityLimit;
return this;
}

@jack-berg jack-berg requested a review from a team as a code owner March 4, 2025 20:33
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (3c71b79) to head (9fd5d9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7169      +/-   ##
============================================
+ Coverage     89.88%   89.91%   +0.03%     
  Complexity     6631     6631              
============================================
  Files           740      740              
  Lines         20033    20026       -7     
  Branches       1968     1968              
============================================
+ Hits          18006    18007       +1     
+ Misses         1438     1430       -8     
  Partials        589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 5015698 into open-telemetry:main Mar 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants