Skip to content

Stable cardinality limit property otel.java.metrics.cardinality.limit #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jack-berg
Copy link
Member

Declarative config now has a more expressive mechanism for configuring cardinality limits, and there is no standard env var for this defined in the specification. Still, I don't think we should get rid of support for specifying cardinality limits via env vars / system properties. So let's stabilize otel.experimental.metrics.cardinality.limit as a java-specific property with name otel.java.metrics.cardinality.limit.

@jack-berg jack-berg requested a review from a team as a code owner March 13, 2025 22:02
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (0673fcf) to head (057a5e0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7199   +/-   ##
=========================================
  Coverage     89.92%   89.92%           
- Complexity     6677     6682    +5     
=========================================
  Files           750      750           
  Lines         20173    20178    +5     
  Branches       1981     1984    +3     
=========================================
+ Hits          18141    18146    +5     
  Misses         1436     1436           
  Partials        596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 09bac7d into open-telemetry:main Mar 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants