-
Notifications
You must be signed in to change notification settings - Fork 900
Sdk builders extended with addProcessorFirst methods #7243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7243 +/- ##
============================================
+ Coverage 89.60% 89.62% +0.01%
- Complexity 6859 6862 +3
============================================
Files 780 780
Lines 20728 20735 +7
Branches 2018 2018
============================================
+ Hits 18574 18584 +10
+ Misses 1514 1512 -2
+ Partials 640 639 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/LogRecordProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but should also add the equivalent method to tracing
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLoggerProviderBuilder.java
Show resolved
Hide resolved
* @param processor the log processor | ||
* @return this | ||
*/ | ||
public SdkLoggerProviderBuilder addLogRecordProcessorFirst(LogRecordProcessor processor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name follows the naming convention of Deque#addFirst
, albeit "LogRecordProcessor" inserted between "add" and "First".
While it initially seems like a verbose name, I think its probably the best we can do to balance consistency with the existing "addLogRecordProcessor" and the precedent in java with Deque#addFirst
.
Resolves the issue #6599.