chore: add workflow for surveys of non-members#7640
chore: add workflow for surveys of non-members#7640jkwatson merged 8 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7640 +/- ##
============================================
- Coverage 90.01% 90.01% -0.01%
+ Complexity 7091 7090 -1
============================================
Files 803 803
Lines 21443 21443
Branches 2092 2092
============================================
- Hits 19302 19301 -1
Misses 1477 1477
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [closed] |
There was a problem hiding this comment.
Is there a distinction here between closed and merged? I forget...but might it create a weird experience if a closed PR offers the same survey and claims it was merged?
There was a problem hiding this comment.
there is no distinction on the type here, but this is to trigger the event, and a few lines below (line 21) there is a check if: github.event.pull_request.merged == true before adding the comment, so it shouldn't comment if is just closed
breedx-splk
left a comment
There was a problem hiding this comment.
This stuff is magic and I love it.
| echo "MEMBER_FOUND=false" >> $GITHUB_ENV | ||
| fi | ||
| env: | ||
| GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} |
There was a problem hiding this comment.
oh no, I've been trying to get rid of opentelemetrybot 😄 open-telemetry/community#2863
can you use the new otelbot app, and same as you roll this out to other repos?
There was a problem hiding this comment.
to confirm, is just replacing with steps.otelbot-token.outputs.token and should be available for all repos, or is there something I need to do to have it available on the repos I'm adding this survey?
I'm adding to:
- collector, which looks like is ready to use
- .NET, which doesn't seem to be ready to use according to this
This survey already exists like this in:
- JS repo, no idea if it can be updated
- opentelemetry.io, which doesn't look like I can update according to the same comment as the .NET one
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
|
Oops looks like I broke it, will investigate 🙈 |
|
looks like that fixed it: open-telemetry/opentelemetry-java-instrumentation#14600 |
|
though I'm now confused, because I only just now "accepted" the permission update to otelbot (forgot there was a second step) 🤔 |
|
looks like that permission was not required for all the prior use cases? will keep an eye if this will continue working as expected now |
|
same, I'll copy you if I see anything unusual this week |
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
The Contributor Experience group created a survey to help understand challenges and feedback from new contributors. We have this survey running for a few months on opentelemetry.io and the JS repo, with helpful feedback, so now adding to more repos.
Example of message: open-telemetry/opentelemetry-js#5884 (comment)