Skip to content

chore: add workflow for surveys of non-members#7640

Merged
jkwatson merged 8 commits intoopen-telemetry:mainfrom
maryliag:create-survey
Sep 6, 2025
Merged

chore: add workflow for surveys of non-members#7640
jkwatson merged 8 commits intoopen-telemetry:mainfrom
maryliag:create-survey

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented Sep 4, 2025

The Contributor Experience group created a survey to help understand challenges and feedback from new contributors. We have this survey running for a few months on opentelemetry.io and the JS repo, with helpful feedback, so now adding to more repos.

Example of message: open-telemetry/opentelemetry-js#5884 (comment)

@maryliag maryliag requested a review from a team as a code owner September 4, 2025 18:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (7ef1410) to head (3e2f302).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7640      +/-   ##
============================================
- Coverage     90.01%   90.01%   -0.01%     
+ Complexity     7091     7090       -1     
============================================
  Files           803      803              
  Lines         21443    21443              
  Branches       2092     2092              
============================================
- Hits          19302    19301       -1     
  Misses         1477     1477              
- Partials        664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


on:
pull_request_target:
types: [closed]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a distinction here between closed and merged? I forget...but might it create a weird experience if a closed PR offers the same survey and claims it was merged?

Copy link
Copy Markdown
Contributor Author

@maryliag maryliag Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no distinction on the type here, but this is to trigger the event, and a few lines below (line 21) there is a check if: github.event.pull_request.merged == true before adding the comment, so it shouldn't comment if is just closed

Copy link
Copy Markdown
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff is magic and I love it.

echo "MEMBER_FOUND=false" >> $GITHUB_ENV
fi
env:
GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, I've been trying to get rid of opentelemetrybot 😄 open-telemetry/community#2863

can you use the new otelbot app, and same as you roll this out to other repos?

Copy link
Copy Markdown
Contributor Author

@maryliag maryliag Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm, is just replacing with steps.otelbot-token.outputs.token and should be available for all repos, or is there something I need to do to have it available on the repos I'm adding this survey?

I'm adding to:

  • collector, which looks like is ready to use
  • .NET, which doesn't seem to be ready to use according to this

This survey already exists like this in:

  • JS repo, no idea if it can be updated
  • opentelemetry.io, which doesn't look like I can update according to the same comment as the .NET one

Comment thread .github/workflows/survey-on-merged-pr.yml Outdated
Comment thread .github/workflows/survey-on-merged-pr.yml Outdated
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jkwatson jkwatson merged commit 570aeda into open-telemetry:main Sep 6, 2025
29 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Sep 6, 2025

Thank you for your contribution @maryliag! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@trask
Copy link
Copy Markdown
Member

trask commented Sep 6, 2025

Oops looks like I broke it, will investigate 🙈

@maryliag maryliag deleted the create-survey branch September 6, 2025 16:30
@trask
Copy link
Copy Markdown
Member

trask commented Sep 6, 2025

@trask
Copy link
Copy Markdown
Member

trask commented Sep 6, 2025

looks like that fixed it: open-telemetry/opentelemetry-java-instrumentation#14600

@trask
Copy link
Copy Markdown
Member

trask commented Sep 6, 2025

though I'm now confused, because I only just now "accepted" the permission update to otelbot (forgot there was a second step) 🤔

@maryliag
Copy link
Copy Markdown
Contributor Author

maryliag commented Sep 7, 2025

looks like that permission was not required for all the prior use cases? will keep an eye if this will continue working as expected now

@trask
Copy link
Copy Markdown
Member

trask commented Sep 8, 2025

same, I'll copy you if I see anything unusual this week

the-clam pushed a commit to the-clam/opentelemetry-java that referenced this pull request Nov 6, 2025
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants