refactor(configuration): throw warning and not error for invalid files (#6124)

Author: maryliag

experimental/CHANGELOG.md

@@ -16,6 +16,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 * feat(configuration): set meter provider exporter type from env variable [#6105](https://github.com/open-telemetry/opentelemetry-js/pull/6105) @maryliag
 * feat(configuration): set tracer provider exporter type from env variables [#6106](https://github.com/open-telemetry/opentelemetry-js/pull/6106) @maryliag
 * feat(configuration): set meter provider exporter type from env variable [#6105](https://github.com/open-telemetry/opentelemetry-js/pull/6105) @maryliag
+* refactor(configuration): throw warning and not error for invalid files [#6124](https://github.com/open-telemetry/opentelemetry-js/pull/6124) @maryliag
 
 ### :bug: Bug Fixes
 

experimental/packages/configuration/src/FileConfigFactory.ts

@@ -60,6 +60,7 @@ import {
   ViewSelector,
   ViewStream,
 } from './models/meterProviderModel';
+import { diag } from '@opentelemetry/api';
 
 export class FileConfigFactory implements ConfigFactory {
   private _config: ConfigurationModel;
@@ -81,9 +82,10 @@ export function hasValidConfigFile(): boolean {
       !(configFile.endsWith('.yaml') || configFile.endsWith('.yml')) ||
       !fs.existsSync(configFile)
     ) {
-      throw new Error(
+      diag.warn(
         `Config file ${configFile} set on OTEL_EXPERIMENTAL_CONFIG_FILE is not valid`
       );
+      return false;
     }
     return true;
   }
@@ -156,7 +158,7 @@ export function parseConfigFile(config: ConfigurationModel) {
     setMeterProvider(config, parsedContent['meter_provider']);
     setLoggerProvider(config, parsedContent['logger_provider']);
   } else {
-    throw new Error(
+    diag.warn(
       `Unsupported File Format: ${parsedContent['file_format']}. It must be one of the following: ${supportedFileVersions}`
     );
   }

experimental/packages/configuration/src/index.ts

@@ -17,4 +17,6 @@
 export type { ConfigFactory } from './IConfigFactory';
 export type { ConfigurationModel } from './models/configModel';
 export type { LogRecordExporter as LogRecordExporterModel } from './models/loggerProviderModel';
+export type { PushMetricExporter as MeterExporterModel } from './models/meterProviderModel';
+export type { SpanExporter as SpanExporterModel } from './models/tracerProviderModel';
 export { createConfigFactory } from './ConfigFactory';

experimental/packages/configuration/test/ConfigFactory.test.ts

@@ -15,8 +15,9 @@
  */
 
 import * as assert from 'assert';
+import * as Sinon from 'sinon';
 import { ConfigurationModel } from '../src';
-import { DiagLogLevel } from '@opentelemetry/api';
+import { diag, DiagLogLevel } from '@opentelemetry/api';
 import { createConfigFactory } from '../src/ConfigFactory';
 import { OtlpHttpEncoding } from '../src/models/commonModel';
 import {
@@ -751,6 +752,7 @@ describe('ConfigFactory', function () {
     for (const [key, value] of Object.entries(_origEnvVariables)) {
       process.env[key] = value;
     }
+    Sinon.restore();
   });
 
   describe('get values from environment variables', function () {
@@ -1935,17 +1937,23 @@ describe('ConfigFactory', function () {
     });
 
     it('should return error from invalid config file', function () {
+      const warnSpy = Sinon.spy(diag, 'warn');
       process.env.OTEL_EXPERIMENTAL_CONFIG_FILE = './fixtures/kitchen-sink.txt';
-      assert.throws(() => {
-        createConfigFactory();
-      });
+      createConfigFactory();
+      Sinon.assert.calledWith(
+        warnSpy,
+        'Config file ./fixtures/kitchen-sink.txt set on OTEL_EXPERIMENTAL_CONFIG_FILE is not valid'
+      );
     });
 
     it('should return error from invalid config file format', function () {
+      const warnSpy = Sinon.spy(diag, 'warn');
       process.env.OTEL_EXPERIMENTAL_CONFIG_FILE = 'test/fixtures/invalid.yaml';
-      assert.throws(() => {
-        createConfigFactory();
-      });
+      createConfigFactory();
+      Sinon.assert.calledWith(
+        warnSpy,
+        'Unsupported File Format: invalid. It must be one of the following: 1.0-rc.1,1.0-rc.2'
+      );
     });
 
     it('should initialize config with default values with empty string for config file', function () {