Skip to content

refactor(configuration): throw warning and not error for invalid files#6124

Merged
maryliag merged 7 commits intoopen-telemetry:mainfrom
maryliag:config-error
Nov 18, 2025
Merged

refactor(configuration): throw warning and not error for invalid files#6124
maryliag merged 7 commits intoopen-telemetry:mainfrom
maryliag:config-error

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

Throw a warning and not an error for invalid config files.
It also exports model required for later usage in other PRs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (6bd0bc4) to head (4313e7a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6124   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         316      316           
  Lines        9388     9390    +2     
  Branches     2168     2168           
=======================================
+ Hits         8939     8941    +2     
  Misses        449      449           
Files with missing lines Coverage Δ
...al/packages/configuration/src/FileConfigFactory.ts 94.05% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording nitpicking

Comment thread experimental/packages/configuration/src/EnvironmentConfigFactory.ts
Copy link
Copy Markdown
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the revisit !

@maryliag maryliag added this pull request to the merge queue Nov 18, 2025
Merged via the queue into open-telemetry:main with commit 158ecf3 Nov 18, 2025
27 checks passed
@maryliag maryliag deleted the config-error branch November 18, 2025 17:05
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants