feat(exporters): update proto version and use otlp-transformer#2929
feat(exporters): update proto version and use otlp-transformer#2929dyladan merged 32 commits intoopen-telemetry:mainfrom
Conversation
dd69e8e to
4d01b43
Compare
Codecov Report
@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 92.97% 92.88% -0.09%
==========================================
Files 185 182 -3
Lines 6089 5906 -183
Branches 1304 1253 -51
==========================================
- Hits 5661 5486 -175
+ Misses 428 420 -8
|
…d spanId in browser exporter.
37a4073 to
78720de
Compare
vmarchaud
left a comment
There was a problem hiding this comment.
overall lgtm, did you test with the collector ? if so, with which version of the collector ? I believe we need to update the readme for it to have a minimal compatible version, WDYT ?
I did test it with |
…ySpans -> scopeSpans
|
@vmarchaud I updated the READMEs to include minimum and maximum tested versions. 🙂 I found that with these updates
for both traces and metrics. |
blumamir
left a comment
There was a problem hiding this comment.
LGTM. There are few open discussions and nits but they are not blockers.
legendecas
left a comment
There was a problem hiding this comment.
Overall LGTM. Just a few nits.
dyladan
left a comment
There was a problem hiding this comment.
Once @legendecas's nit is resolved this can be merged IMO
legendecas
left a comment
There was a problem hiding this comment.
This is a great job. Thank you!
Which problem is this PR solving?
The proto version was outdated, which causes problems with newer collector versions. This PR updates the proto version to
0.16, and makes use of theotlp-transformerpackage introduced in #2746.Fixes #2886, #2675
Type of change
non-breakingchange which fixes an issue)non-breakingchange which adds functionality)How Has This Been Tested?
Checklist: