You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary: This PR allows to optionally disable adding network events as span events to control the total volume of telemetry data produced.
Some of the modern vendors treat spans and span events (annotations) equally – both are counted towards the overall retained events volume. Similarly, vendors that charge for the overall size of data retained will count span annotations as part of the data. Typically, span produced by the @opentelemetry-instrumentation-fetch includes 9 network events – 10 event items along with the span itself. It would be great to have ability to optionally disable network events being added as span annotations to reduce the overall volume of data/events generated and eventually retained.
Short description of the changes
This PR adds an optional boolean flag ignoreNetworkEvents to the FetchInstrumentation. When set to true network events are not added to the span.
Type of change
Please delete options that are not relevant.
New feature (non-breaking change which adds functionality)
This change requires a documentation update
How Has This Been Tested?
Running npm run test:browser will run the newly added test as part of the suite:
...
when network events are ignored
✓ should NOT add network events
Merging #3028 (e36c928) into main (c8c4ec6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.
❗ Current head e36c928 differs from pull request most recent head 07a3f0f. Consider uploading reports for the commit 07a3f0f to get more accurate results
Ah, thank you @vmarchaud. I modified experimental/CHANGELOG – I hope that's what you've meant by "global" – I figured the one in experimental fits better as my change is for the package located under experimental directory.
I hope that's what you've meant by "global" – I figured the one in experimental fits better as my change is for the package located under experimental directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Summary: This PR allows to optionally disable adding network events as span events to control the total volume of telemetry data produced.
Some of the modern vendors treat spans and span events (annotations) equally – both are counted towards the overall retained events volume. Similarly, vendors that charge for the overall size of data retained will count span annotations as part of the data. Typically, span produced by the
@opentelemetry-instrumentation-fetchincludes 9 network events – 10 event items along with the span itself. It would be great to have ability to optionally disable network events being added as span annotations to reduce the overall volume of data/events generated and eventually retained.Short description of the changes
This PR adds an optional boolean flag
ignoreNetworkEventsto theFetchInstrumentation. When set totruenetwork events are not added to the span.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running
npm run test:browserwill run the newly added test as part of the suite:Checklist: