fix: don't let PeriodicExportingMetricReader block process exit#3106
Merged
vmarchaud merged 2 commits intoopen-telemetry:mainfrom Jul 23, 2022
Merged
fix: don't let PeriodicExportingMetricReader block process exit#3106vmarchaud merged 2 commits intoopen-telemetry:mainfrom
vmarchaud merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 93.08% 91.98% -1.10%
==========================================
Files 188 82 -106
Lines 6243 2407 -3836
Branches 1313 522 -791
==========================================
- Hits 5811 2214 -3597
+ Misses 432 193 -239
|
pichlermarc
approved these changes
Jul 22, 2022
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Looks great. Thanks for adding this! 🙂
vmarchaud
approved these changes
Jul 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeriodicExportingMetricReadercurrently keeps the Node.js process from exiting when not doing an explicit shutdown.