chore(sdk-metrics): clean up exports#3197
Merged
legendecas merged 6 commits intoopen-telemetry:mainfrom Aug 29, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3197 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 196 196
Lines 6443 6443
Branches 1363 1363
=======================================
Hits 6006 6006
Misses 437 437
|
legendecas
reviewed
Aug 24, 2022
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Thank you for working on this.
MSNev
reviewed
Aug 24, 2022
| export { TimeoutError } from './utils'; | ||
| export * from './view/Aggregation'; | ||
| export * from './view/View'; | ||
| export { |
Contributor
There was a problem hiding this comment.
👍 We should be explicit about what is exported.
MSNev
approved these changes
Aug 24, 2022
legendecas
reviewed
Aug 26, 2022
legendecas
approved these changes
Aug 26, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/sdk-metricsexports some classes and functions that are intended for internal use. In an effort to reduce the API surface before declaring metrics GA, this PR replaces the existing wildcard exports with explicit exports.Related: #3158
Short description of the changes
Replaces the existing wildcard exports with explicit exports and removes export for:
CollectionResultTimeoutErrorType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: