feat(sdk-node)!: Automatically configure logs exporter#4740
Merged
trentm merged 19 commits intoopen-telemetry:mainfrom Aug 19, 2024
Merged
feat(sdk-node)!: Automatically configure logs exporter#4740trentm merged 19 commits intoopen-telemetry:mainfrom
trentm merged 19 commits intoopen-telemetry:mainfrom
Conversation
JacksonWeber
reviewed
Jun 4, 2024
pichlermarc
reviewed
Jun 18, 2024
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Thanks for working on this. I had a few comments, but overall looks good. 🙂
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4740 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 89 89
Lines 1954 1955 +1
Branches 416 416
=======================================
+ Hits 1779 1780 +1
Misses 175 175 |
trentm
reviewed
Jul 3, 2024
4 tasks
Contributor
Author
|
All comments should be addressed @trentm @pichlermarc |
trentm
reviewed
Aug 9, 2024
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
This looks great. Just a few nits.
trentm
reviewed
Aug 16, 2024
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
LGTM, just the one discussion about calling this a breaking change (for the microscopic type change).
mhennoch
changed the title
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #4552 #4451
Short description of the changes
See #4552. I hope changes to
LoggerProviderConfigare not breaking. It is exported but I don't think anyone is using it.Type of change
Checklist: