Converge sync and async resources#5350
Merged
dyladan merged 28 commits intoopen-telemetry:mainfrom Feb 3, 2025
Merged
Conversation
pichlermarc
reviewed
Jan 17, 2025
pichlermarc
reviewed
Jan 17, 2025
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Thank you for working on this 🙂
A quick preliminary review - I'll have a closer look at the implementation details next week :)
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 22, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
approved these changes
Jan 23, 2025
Contributor
chancancode
left a comment
There was a problem hiding this comment.
Take it with an unhealthy amount of salt, but other than the suggestions I left (feel free to make your own judgment call), it looks good to me!
trentm
approved these changes
Jan 23, 2025
Contributor
trentm
left a comment
There was a problem hiding this comment.
I think this LGTM.
I asked a Q at #5358 (comment)
I'm not totally clear on what the user's experience with resources (usage with the SDK I mean) will be after these changes at #5358, especially when Entities come along.
david-luna
reviewed
Jan 29, 2025
david-luna
approved these changes
Jan 30, 2025
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3582
This PR makes it so that any resource detector can detect sync and async resources, returning both in a single resource object.
attributeskey, which all attributes are nested under. This will make it easier to extend for entities in the future by adding a new key to the object.To be done in follow-up: