fix(exporter-logs/trace-otlp-grpc): fix error for missing dependency otlp-exporter-base#5412
Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom Feb 6, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
- Coverage 94.65% 94.64% -0.02%
==========================================
Files 317 317
Lines 8025 8025
Branches 1687 1687
==========================================
- Hits 7596 7595 -1
- Misses 429 430 +1 |
dyladan
approved these changes
Feb 5, 2025
trentm
approved these changes
Feb 5, 2025
Member
|
thank you @JamieDanielson - can you backport this to the |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#5031 was a large refactor for OTLP exporters, and a dependency that was previously listed as a dev dependency is now required as a production dependency. Upgrading to experimental/v0.56.0 caused an error in Yarn PnP:
Short description of the changes
@opentelemetry/otlp-exporter-baseto be production dependencyType of change
How Has This Been Tested?
lint:depscommand to the rootpackage.jsonand running locally."lint:deps": "npx --yes knip@5.33.3 --dependencies --production --strict",