fix(instrumentation-http): report error.type metrics attribute#5647
Merged
pichlermarc merged 3 commits intoopen-telemetry:mainfrom Aug 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5647 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 303 303
Lines 7946 7946
Branches 1607 1607
=======================================
Hits 7550 7550
Misses 396 396 🚀 New features to boost your workflow:
|
hectorhdzg
reviewed
May 7, 2025
hectorhdzg
approved these changes
May 7, 2025
Member
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, just nit comment about method name
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Member
Author
|
Bad bot |
Member
|
Bad me for letting this get stale :/ |
dyladan
approved these changes
Jul 16, 2025
raphael-theriault-swi
force-pushed
the
http-metrics-error-type
branch
from
5626ec1 to
279727e
Compare
Member
Author
|
@dyladan rebased on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This reports the
error.typeattribute on HTTP metrics wherever it is already reported on HTTP spans as required by the spec.Fixes #5627
Short description of the changes
Updates the metrics attributes from the
_on***Errorhelpers and uses those wherever appropriate.Type of change
How Has This Been Tested?
I added a test for client metrics but couldn't figure out a way to test server metrics since it involves throwing within the server request handler which is an uncaught exception.
Checklist: