Skip to content

feat(exporter-metrics-otlp-proto): Support to protobuf in browser metrics#5710

Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
YangJonghun:feat/support-protobuf-in-browser-metrics
May 27, 2025
Merged

feat(exporter-metrics-otlp-proto): Support to protobuf in browser metrics#5710
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
YangJonghun:feat/support-protobuf-in-browser-metrics

Conversation

@YangJonghun
Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

Log, Trace support protobuf properly in browser, but Metric crashes because it references @opentelemetry/otlp-exporter-base/node-http.

Short description of the changes

  • Meter Exporter supports protobuf in browser

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@YangJonghun YangJonghun requested a review from a team as a code owner May 24, 2025 07:54
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@pichlermarc
Copy link
Copy Markdown
Member

@YangJonghun thanks for working on this :)
Please also add an entry in experimental/CHANGELOG.md.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (a9fc600) to head (6e0733b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5710   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         310      310           
  Lines        7998     7998           
  Branches     1615     1615           
=======================================
  Hits         7601     7601           
  Misses        397      397           
Files with missing lines Coverage Δ
...otlp-proto/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YangJonghun
Copy link
Copy Markdown
Contributor Author

@pichlermarc
Thanks for your quick review. I've added an entry into the CHANGELOG.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pichlermarc pichlermarc added this pull request to the merge queue May 27, 2025
Merged via the queue into open-telemetry:main with commit 4919fd1 May 27, 2025
19 checks passed
@opentelemetrybot
Copy link
Copy Markdown
Contributor

Thank you for your contribution @YangJonghun! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@YangJonghun YangJonghun deleted the feat/support-protobuf-in-browser-metrics branch June 3, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter-metrics-otlp-proto] Add browser support

3 participants