feat(opentelemetry-configuration): parse more parameters from config file#5955
Merged
maryliag merged 12 commits intoopen-telemetry:mainfrom Oct 8, 2025
Merged
feat(opentelemetry-configuration): parse more parameters from config file#5955maryliag merged 12 commits intoopen-telemetry:mainfrom
maryliag merged 12 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5955 +/- ##
==========================================
+ Coverage 95.17% 95.21% +0.04%
==========================================
Files 316 316
Lines 8521 8598 +77
Branches 1763 1791 +28
==========================================
+ Hits 8110 8187 +77
Misses 411 411
🚀 New features to boost your workflow:
|
pichlermarc
reviewed
Sep 25, 2025
Member
pichlermarc
left a comment
There was a problem hiding this comment.
overall looks good, but one spooky any that I'm concerned about. 👻
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5955 +/- ##
==========================================
+ Coverage 95.17% 95.22% +0.04%
==========================================
Files 316 316
Lines 8526 8599 +73
Branches 1766 1791 +25
==========================================
+ Hits 8115 8188 +73
Misses 411 411
🚀 New features to boost your workflow:
|
pichlermarc
requested changes
Oct 7, 2025
…o parse-more-parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the added parameters to the config model, this PR parses:
The Tracer/Meter/Logger providers require more parsing of complex parameters, so I'll keep those into a separate PR to facilitate the review. This PR focus on the ones that are straight forward