Skip to content

feat(opentelemetry-configuration): parse more parameters from config file#5955

Merged
maryliag merged 12 commits intoopen-telemetry:mainfrom
maryliag:parse-more-parameters
Oct 8, 2025
Merged

feat(opentelemetry-configuration): parse more parameters from config file#5955
maryliag merged 12 commits intoopen-telemetry:mainfrom
maryliag:parse-more-parameters

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented Sep 23, 2025

After the added parameters to the config model, this PR parses:

  • attribute limits
  • propagator
  • partial tracer provider
  • partial meter provider
  • partial logger provider

The Tracer/Meter/Logger providers require more parsing of complex parameters, so I'll keep those into a separate PR to facilitate the review. This PR focus on the ones that are straight forward

@maryliag maryliag requested a review from a team as a code owner September 23, 2025 21:23
@maryliag maryliag changed the title feat(opentelemetry-configuration): parse parameter from config file feat(opentelemetry-configuration): parse more parameters from config file Sep 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (3dc8979) to head (01497ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5955      +/-   ##
==========================================
+ Coverage   95.17%   95.21%   +0.04%     
==========================================
  Files         316      316              
  Lines        8521     8598      +77     
  Branches     1763     1791      +28     
==========================================
+ Hits         8110     8187      +77     
  Misses        411      411              
Files with missing lines Coverage Δ
...try-configuration/src/EnvironmentConfigProvider.ts 98.94% <100.00%> (+0.01%) ⬆️
...ntelemetry-configuration/src/FileConfigProvider.ts 100.00% <100.00%> (ø)
.../packages/opentelemetry-configuration/src/utils.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, but one spooky any that I'm concerned about. 👻

Comment thread experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (33d3599) to head (f01114d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5955      +/-   ##
==========================================
+ Coverage   95.17%   95.22%   +0.04%     
==========================================
  Files         316      316              
  Lines        8526     8599      +73     
  Branches     1766     1791      +25     
==========================================
+ Hits         8115     8188      +73     
  Misses        411      411              
Files with missing lines Coverage Δ
...try-configuration/src/EnvironmentConfigProvider.ts 98.95% <100.00%> (+0.02%) ⬆️
...ntelemetry-configuration/src/FileConfigProvider.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-configuration/src/configModel.ts 100.00% <ø> (ø)
.../packages/opentelemetry-configuration/src/utils.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/packages/opentelemetry-configuration/src/utils.ts Outdated
Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

@maryliag maryliag added this pull request to the merge queue Oct 8, 2025
Merged via the queue into open-telemetry:main with commit 77c48d2 Oct 8, 2025
23 checks passed
@maryliag maryliag deleted the parse-more-parameters branch October 8, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants