fix(instrumentation-http): remove port from ATTR_CLIENT_ADDRESS

[cjihrig]

Which problem is this PR solving?

The problem is that ATTR_CLIENT_ADDRESS is being set with a port if one was provided in the relevant headers.

Fixes #5933

Short description of the changes

This commit updates getRemoteClientAddress() to strip any detected ports from the Forwarded or X-Forwarded-For headers. It also increases test coverage for the function.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Existing test suite
• Tests added in this PR

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (bfede57) to head (77e5c27).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5957   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         316      316           
  Lines        8521     8521           
  Branches     1763     1763           
=======================================
  Hits         8110     8110           
  Misses        411      411           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cjihrig]

@pichlermarc could I trouble you for a review?

[pichlermarc]

looks good, thanks 🙂

[otelbot]

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.