Skip to content

feat(exporter-prometheus): support withoutTargetInfo option#5962

Merged
pichlermarc merged 4 commits intoopen-telemetry:mainfrom
cjihrig:wo-target-info
Oct 7, 2025
Merged

feat(exporter-prometheus): support withoutTargetInfo option#5962
pichlermarc merged 4 commits intoopen-telemetry:mainfrom
cjihrig:wo-target-info

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Sep 29, 2025

Which problem is this PR solving?

This commit adds support for the without_target_info option (converted to camelCase to match other options) from the spec.

Fixes # N/A

Short description of the changes

This commit adds support for the without_target_info option (converted to camelCase to match other options) from the spec.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Existing tests
  • Tests added

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

This commit adds support for the without_target_info option
(converted to camelCase to match other options) from the spec.
@cjihrig cjihrig requested a review from a team as a code owner September 29, 2025 00:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (06621d2) to head (b75a176).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5962      +/-   ##
==========================================
- Coverage   95.17%   95.16%   -0.01%     
==========================================
  Files         316      316              
  Lines        8521     8526       +5     
  Branches     1763     1766       +3     
==========================================
+ Hits         8110     8114       +4     
- Misses        411      412       +1     
Files with missing lines Coverage Δ
...etry-exporter-prometheus/src/PrometheusExporter.ts 96.62% <100.00%> (+0.07%) ⬆️
...ry-exporter-prometheus/src/PrometheusSerializer.ts 96.17% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks 🙂

Comment thread experimental/CHANGELOG.md Outdated
@pichlermarc pichlermarc added this pull request to the merge queue Oct 7, 2025
Merged via the queue into open-telemetry:main with commit ed7ee0d Oct 7, 2025
25 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Oct 7, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the wo-target-info branch October 7, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants