Skip to content

test(otlp-grpc-exporter-base): remove duplicated delete statements#6022

Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
cjihrig:extra-deletes
Oct 17, 2025
Merged

test(otlp-grpc-exporter-base): remove duplicated delete statements#6022
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
cjihrig:extra-deletes

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Oct 17, 2025

Which problem is this PR solving?

There are duplicated delete statements in some of the test cleanup code in otlp-grpc-exporter-base. You can see in the diff that the duplicated statements were immediately following each other.

Fixes # N/A

Short description of the changes

This commit removes the duplicated delete statements.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing test suite.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner October 17, 2025 11:46
Comment thread experimental/CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (6854413) to head (0a610cc).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6022   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         313      313           
  Lines        8799     8799           
  Branches     1888     1888           
=======================================
  Hits         8360     8360           
  Misses        439      439           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pichlermarc pichlermarc added this pull request to the merge queue Oct 17, 2025
Merged via the queue into open-telemetry:main with commit a39500d Oct 17, 2025
25 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Oct 17, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the extra-deletes branch October 17, 2025 12:07
maryliag pushed a commit to maryliag/opentelemetry-js that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants