refactor(instrumentation-http): avoid deprecated url.parse() in getAbsoluteUrl()#6089
Merged
pichlermarc merged 3 commits intoopen-telemetry:mainfrom Nov 10, 2025
Merged
refactor(instrumentation-http): avoid deprecated url.parse() in getAbsoluteUrl()#6089pichlermarc merged 3 commits intoopen-telemetry:mainfrom
url.parse() in getAbsoluteUrl()#6089pichlermarc merged 3 commits intoopen-telemetry:mainfrom
Conversation
cjihrig
commented
Nov 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6089 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 316 316
Lines 9207 9207
Branches 2075 2075
=======================================
Hits 8762 8762
Misses 445 445 🚀 New features to boost your workflow:
|
pichlermarc
requested changes
Nov 6, 2025
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Hmm, I think there may be some edge-cases where the instrumentation would throw, but http/https itself would not.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
getAbsoluteUrl()usesurl.parse(), which is deprecated in Node.js.new URL()is preferable.Does not fix all occurrences of
url.parse(), but refers to #6061.Short description of the changes
This commit updates
getAbsoluteUrl()to usenew URL()instead of the deprecatedurl.parse(). As a side effect, the code is a bit simpler.There are some remaining occurrences in tests, but I would prefer to update those separately.
Type of change
How Has This Been Tested?
Checklist: