Skip to content

refactor(configuration): improvements on package#6101

Merged
maryliag merged 10 commits intoopen-telemetry:mainfrom
maryliag:improv-config
Nov 12, 2025
Merged

refactor(configuration): improvements on package#6101
maryliag merged 10 commits intoopen-telemetry:mainfrom
maryliag:improv-config

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

Changes to make the package more compatible with specs:

  • ConfigProvider -> ConfigFactory (and the respective env and file from configProvider to also configFactory
  • getInstrumentationConfig -> getConfigModel (since it returns the entire model, not just the instrumentation part)
  • use the original name ConfigurationModel and doesn't rename it to just Configuration on its export

This PR also renames the package from opentelemetry-configuration to configuration

@maryliag maryliag requested a review from a team as a code owner November 12, 2025 22:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (ded89b5) to head (184242a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6101   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         316      316           
  Lines        9220     9220           
  Branches     2080     2080           
=======================================
  Hits         8774     8774           
  Misses        446      446           
Files with missing lines Coverage Δ
...mental/packages/configuration/src/ConfigFactory.ts 100.00% <100.00%> (ø)
...ages/configuration/src/EnvironmentConfigFactory.ts 100.00% <100.00%> (ø)
...al/packages/configuration/src/FileConfigFactory.ts 94.03% <100.00%> (ø)
...l/packages/configuration/src/models/commonModel.ts 100.00% <ø> (ø)
...l/packages/configuration/src/models/configModel.ts 100.00% <ø> (ø)
...es/configuration/src/models/loggerProviderModel.ts 100.00% <ø> (ø)
...ges/configuration/src/models/meterProviderModel.ts 100.00% <ø> (ø)
...es/configuration/src/models/tracerProviderModel.ts 100.00% <ø> (ø)
experimental/packages/configuration/src/utils.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/packages/configuration/package.json
Copy link
Copy Markdown
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could call this a "refactor" if you like, rather that "feat", but all good either way.

@maryliag maryliag changed the title feat(configuration): improvements on package refactor(configuration): improvements on package Nov 12, 2025
@maryliag maryliag added this pull request to the merge queue Nov 12, 2025
Merged via the queue into open-telemetry:main with commit 66ee4d6 Nov 12, 2025
27 checks passed
@maryliag maryliag deleted the improv-config branch November 12, 2025 23:36
vitorvasc added a commit to open-telemetry/opentelemetry.io that referenced this pull request Nov 19, 2025
…en-telemetry/opentelemetry-js#6101)

Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants