test(instrumentation-http): make timing dependent test more robust#6144
Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom Nov 21, 2025
Merged
test(instrumentation-http): make timing dependent test more robust#6144pichlermarc merged 2 commits intoopen-telemetry:mainfrom
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
Conversation
cjihrig
commented
Nov 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6144 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 316 316
Lines 9389 9389
Branches 2167 2167
=======================================
Hits 8940 8940
Misses 449 449 🚀 New features to boost your workflow:
|
pichlermarc
approved these changes
Nov 21, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The test
should have 2 ended span when client prematurely closerelies on specific timing of asynchronous events. This leads to it being flaky in the CI.Fixes # https://github.com/open-telemetry/opentelemetry-js/actions/runs/19544684677/job/55960292192
Short description of the changes
This commit updates the test to use a polling mechanism instead of relying on timers of specific durations.
Type of change
How Has This Been Tested?
Checklist: