Skip to content

feat(opentelemetry-sdk-node): set instrumentation and propagators for experimental start#6148

Merged
maryliag merged 19 commits intoopen-telemetry:mainfrom
maryliag:rsc-instru
Nov 21, 2025
Merged

feat(opentelemetry-sdk-node): set instrumentation and propagators for experimental start#6148
maryliag merged 19 commits intoopen-telemetry:mainfrom
maryliag:rsc-instru

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented Nov 21, 2025

Register instrumentation from sdkOptions and set propagators (sdkOptions or config)

@maryliag maryliag changed the title Rsc instru feat(opentelemetry-sdk-node): set instrumentation and propagators for experimental start Nov 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.40%. Comparing base (bca04fd) to head (f5fb278).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ental/packages/opentelemetry-sdk-node/src/start.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6148   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         317      317           
  Lines        9392     9433   +41     
  Branches     2167     2178   +11     
=======================================
+ Hits         8960     9000   +40     
- Misses        432      433    +1     
Files with missing lines Coverage Δ
...ental/packages/opentelemetry-sdk-node/src/utils.ts 93.86% <100.00%> (+1.61%) ⬆️
...ental/packages/opentelemetry-sdk-node/src/start.ts 96.00% <88.88%> (-4.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag marked this pull request as ready for review November 21, 2025 17:25
@maryliag maryliag requested a review from a team as a code owner November 21, 2025 17:25
Comment thread experimental/packages/opentelemetry-sdk-node/src/types.ts Outdated
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
@JamieDanielson
Copy link
Copy Markdown
Member

Hmm I reran the previous lint job and it worked, I think the new lint error is probably from my suggestion.

Comment thread experimental/packages/opentelemetry-sdk-node/src/types.ts Outdated
@JamieDanielson
Copy link
Copy Markdown
Member

Hmm I reran the previous lint job and it worked, I think the new lint error is probably from my suggestion.

Looks like whitespace, I just committed a change that should fix it

Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
@maryliag maryliag added this pull request to the merge queue Nov 21, 2025
Merged via the queue into open-telemetry:main with commit 169223d Nov 21, 2025
27 checks passed
@maryliag maryliag deleted the rsc-instru branch November 21, 2025 23:13
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Create operation returns Propagators

3 participants