refactor(configuration): simplify boolean check#6158
Merged
maryliag merged 2 commits intoopen-telemetry:mainfrom Nov 24, 2025
Merged
refactor(configuration): simplify boolean check#6158maryliag merged 2 commits intoopen-telemetry:mainfrom
maryliag merged 2 commits intoopen-telemetry:mainfrom
Conversation
cjihrig
commented
Nov 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6158 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 317 317
Lines 9427 9427
Branches 2178 2178
=======================================
Hits 8994 8994
Misses 433 433
🚀 New features to boost your workflow:
|
raphael-theriault-swi
approved these changes
Nov 24, 2025
Member
raphael-theriault-swi
left a comment
There was a problem hiding this comment.
LGTM but I'd still like @maryliag to give her approval :)
maryliag
approved these changes
Nov 24, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
A
disabledcheck in the configuration package is a little confusing to read. The value can betrue,false, orundefined. Instead of checking for a truthy orfalsevalue, the code can be simplified to only a check forundefined.Fixes # N/A
Short description of the changes
This commit updates the confusing check to a single
undefinedcheck.Type of change
None of these.
How Has This Been Tested?
Checklist: