Skip to content

fix(configuration): merge service name from OTEL_SERVICE_NAME instead of replacing all resource attributes#6162

Merged
maryliag merged 4 commits intoopen-telemetry:mainfrom
maryliag:fix-attr
Nov 25, 2025
Merged

fix(configuration): merge service name from OTEL_SERVICE_NAME instead of replacing all resource attributes#6162
maryliag merged 4 commits intoopen-telemetry:mainfrom
maryliag:fix-attr

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

When we had a value in OTEL_SERVICE_NAME it was wrongly replacing the entire attributes list, instead of just the service name value.
This PR fixes that and add a test for this case

@maryliag maryliag requested a review from a team as a code owner November 25, 2025 01:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (315c0f0) to head (9756598).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6162   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         317      317           
  Lines        9427     9430    +3     
  Branches     2180     2183    +3     
=======================================
+ Hits         8994     8997    +3     
  Misses        433      433           
Files with missing lines Coverage Δ
...ages/configuration/src/EnvironmentConfigFactory.ts 99.06% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/packages/configuration/test/ConfigFactory.test.ts Outdated
Copy link
Copy Markdown
Contributor

@JacksonWeber JacksonWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maryliag and others added 2 commits November 25, 2025 09:05
Co-authored-by: Jackson Weber <47067795+JacksonWeber@users.noreply.github.com>
@maryliag maryliag added this pull request to the merge queue Nov 25, 2025
Merged via the queue into open-telemetry:main with commit 9f81074 Nov 25, 2025
27 checks passed
@maryliag maryliag deleted the fix-attr branch November 25, 2025 18:39
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants