fix(instrumentation-fetch): use feature detection for browser environment#6200
Merged
overbalance merged 3 commits intoopen-telemetry:mainfrom Dec 9, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6200 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 317 317
Lines 9521 9521
Branches 2197 2197
=======================================
Hits 9086 9086
Misses 435 435 🚀 New features to boost your workflow:
|
cd8b55a to
301a401
Compare
pichlermarc
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The current browser detection uses Node.js-specific checks (
process.release?.name === 'node'), which doesn't account for other server-side runtimes like Deno and Bun that also havefetch(). This browser-only instrumentation shouldn't attempt to patch fetch in any server-side environment.Short description of the changes
typeof PerformanceObserver !== 'undefined')@opentelemetry/apiType of change
How Has This Been Tested?
Existing browser tests cover this functionality. The feature detection approach checks for
PerformanceObserver, which the instrumentation already depends on.Checklist: