Skip to content

fix(sdk-logs): allow AnyValue attributes for logs and handle circular references. take 2#6210

Merged
david-luna merged 7 commits intoopen-telemetry:mainfrom
david-luna:any-value-for-logs-and-circular-refs
Jan 15, 2026
Merged

fix(sdk-logs): allow AnyValue attributes for logs and handle circular references. take 2#6210
david-luna merged 7 commits intoopen-telemetry:mainfrom
david-luna:any-value-for-logs-and-circular-refs

Conversation

@david-luna
Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

#5765 was close to be completed but it became inactive. This PR takes the original branch and applies the suggestion of moving the validation to the logs SDK package. ref: #5765 (comment)

Fixes #5744

Short description of the changes

same as #5765

@david-luna david-luna requested a review from a team as a code owner December 11, 2025 09:02
@david-luna david-luna changed the title Any value for logs and circular refs fix(api-logs,sdk-logs): allow AnyValue attributes for logs and handle circular references. take 2 Dec 11, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (a1485a2) to head (8dd3b1d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6210      +/-   ##
==========================================
+ Coverage   95.39%   95.41%   +0.02%     
==========================================
  Files         316      317       +1     
  Lines        9549     9597      +48     
  Branches     2207     2220      +13     
==========================================
+ Hits         9109     9157      +48     
  Misses        440      440              
Files with missing lines Coverage Δ
...xperimental/packages/sdk-logs/src/LogRecordImpl.ts 99.12% <100.00%> (+0.86%) ⬆️
...rimental/packages/sdk-logs/src/utils/validation.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review this. This looks good 🙂

Comment thread experimental/CHANGELOG.md Outdated
@pichlermarc pichlermarc changed the title fix(api-logs,sdk-logs): allow AnyValue attributes for logs and handle circular references. take 2 fix(sdk-logs): allow AnyValue attributes for logs and handle circular references. take 2 Jan 14, 2026
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@david-luna david-luna added this pull request to the merge queue Jan 15, 2026
Merged via the queue into open-telemetry:main with commit a982964 Jan 15, 2026
27 checks passed
@david-luna david-luna deleted the any-value-for-logs-and-circular-refs branch January 15, 2026 08:38
maryliag pushed a commit to maryliag/opentelemetry-js that referenced this pull request Jan 15, 2026
… references. take 2 (open-telemetry#6210)

Co-authored-by: Alex Velikanov <alex25368@gmail.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sdk-logs, exporters] investigate if circular refrences are a problem during log record serialization

3 participants