Skip to content

chore(backcompat): fix backcompat tests and tsconfig cleanup#6232

Merged
overbalance merged 4 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/housekeeping-from-revert
Dec 18, 2025
Merged

chore(backcompat): fix backcompat tests and tsconfig cleanup#6232
overbalance merged 4 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/housekeeping-from-revert

Conversation

@overbalance
Copy link
Copy Markdown
Contributor

@overbalance overbalance commented Dec 17, 2025

Follow up to #6225

Which problem is this PR solving?

Fix failing backcompat tests and cleanup config issues and duplicate code.

Short description of the changes

  • Remove duplicate license header in otlp-transformer trace/internal.ts
  • Fix backwards-compatibility tests to use proper tsconfig project references with tsc -p .
  • Remove unnecessary allowJs from sampler-composite tsconfig files
  • Update package-lock.json

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • CI passes

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@overbalance overbalance requested a review from a team as a code owner December 17, 2025 22:26
@overbalance overbalance changed the title chore: housekeeping and config cleanup chore: fix backcompat tests and config cleanup Dec 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (d33623e) to head (999c488).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6232   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         317      317           
  Lines        9518     9518           
  Branches     2194     2194           
=======================================
  Hits         9081     9081           
  Misses        437      437           
Files with missing lines Coverage Δ
...al/packages/otlp-transformer/src/trace/internal.ts 98.59% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance overbalance changed the title chore: fix backcompat tests and config cleanup chore(backcompat): fix backcompat tests and tsconfig cleanup Dec 17, 2025
@pichlermarc
Copy link
Copy Markdown
Member

I think we can fully drop the backcompat tests.
We don't support these versions anymore and we don't ever run them anywhere.

Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a PR to kick out the unused backcompat tests.

@overbalance overbalance added this pull request to the merge queue Dec 18, 2025
Merged via the queue into open-telemetry:main with commit f9c995d Dec 18, 2025
27 checks passed
@overbalance overbalance deleted the overbalance/housekeeping-from-revert branch December 18, 2025 13:59
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants