refactor(sdk-logs): remove wrapper Promise in _flushOneBatch()#6253
Merged
maryliag merged 2 commits intoopen-telemetry:mainfrom Jan 5, 2026
Merged
refactor(sdk-logs): remove wrapper Promise in _flushOneBatch()#6253maryliag merged 2 commits intoopen-telemetry:mainfrom
Promise in _flushOneBatch()#6253maryliag merged 2 commits intoopen-telemetry:mainfrom
Conversation
cjihrig
commented
Dec 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6253 +/- ##
==========================================
- Coverage 95.39% 95.39% -0.01%
==========================================
Files 314 314
Lines 9516 9514 -2
Branches 2198 2198
==========================================
- Hits 9078 9076 -2
Misses 438 438
🚀 New features to boost your workflow:
|
legendecas
approved these changes
Dec 29, 2025
maryliag
approved these changes
Jan 5, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
BatchLogRecordProcessorBasecreates an extra wrapperPromiseon each call to_flushOneBatch().Fixes # N/A
Short description of the changes
This commit removes the extra wrapper
Promiseand directly returns thecallWithTimeout()Promise.Type of change
Performance refactor
How Has This Been Tested?
Checklist: