Skip to content

feat(opentelemetry-sdk-node): set log provider for experimental start#6407

Merged
maryliag merged 10 commits intoopen-telemetry:mainfrom
maryliag:dec-log-prov
Feb 19, 2026
Merged

feat(opentelemetry-sdk-node): set log provider for experimental start#6407
maryliag merged 10 commits intoopen-telemetry:mainfrom
maryliag:dec-log-prov

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

Fixes #5822

I copied all relevant tests from the original SDK start, to make sure the behaviour is the same

@maryliag maryliag requested a review from a team as a code owner February 12, 2026 15:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 98.30508% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.64%. Comparing base (7d866ea) to head (6b843ec).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ental/packages/opentelemetry-sdk-node/src/utils.ts 97.22% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6407      +/-   ##
==========================================
+ Coverage   95.60%   95.64%   +0.04%     
==========================================
  Files         361      362       +1     
  Lines       11624    11736     +112     
  Branches     2696     2733      +37     
==========================================
+ Hits        11113    11225     +112     
  Misses        511      511              
Files with missing lines Coverage Δ
...tal/packages/opentelemetry-sdk-node/src/semconv.ts 100.00% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/start.ts 100.00% <100.00%> (+4.00%) ⬆️
...ental/packages/opentelemetry-sdk-node/src/utils.ts 96.21% <97.22%> (+0.70%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/packages/opentelemetry-sdk-node/test/start.test.ts Outdated
Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few smaller comments. Though I still think that we should do traces, metrics first since they're stable - then logs which is not stable yet (hoping that this won't matter though since I hope we can get logs out the door soon :))

Comment thread experimental/packages/opentelemetry-sdk-node/test/start.test.ts Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
@maryliag maryliag added this pull request to the merge queue Feb 19, 2026
Merged via the queue into open-telemetry:main with commit 2f7c372 Feb 19, 2026
27 checks passed
@maryliag maryliag deleted the dec-log-prov branch February 19, 2026 19:50
gotgenes added a commit to gotgenes/opentelemetry-js that referenced this pull request Mar 23, 2026
…-base dependency

The import of CompressionAlgorithm from @opentelemetry/otlp-exporter-base was
added in open-telemetry#6407 but the dependency was not added to package.json. This causes
a runtime error under strict package managers like pnpm that do not hoist
transitive dependencies.

Signed-off-by: Chris Lasher <chris.lasher@gmail.com>
gotgenes added a commit to gotgenes/opentelemetry-js that referenced this pull request Mar 23, 2026
…-base dependency

The import of CompressionAlgorithm from @opentelemetry/otlp-exporter-base was
added in open-telemetry#6407 but the dependency was not added to package.json. This causes
a runtime error under strict package managers like pnpm that do not hoist
transitive dependencies.

Signed-off-by: Chris Lasher <chris.lasher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Create operation returns LoggerProvider

3 participants