fix(web-common): add limit for timeout#6601
Merged
pichlermarc merged 6 commits intoopen-telemetry:mainfrom Apr 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6601 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 375 375
Lines 12818 12820 +2
Branches 3056 3056
=======================================
+ Hits 12272 12274 +2
Misses 546 546
🚀 New features to boost your workflow:
|
overbalance
reviewed
Apr 16, 2026
Contributor
overbalance
left a comment
There was a problem hiding this comment.
You may want to use a constant for the magic number now that there are two instances of 2147483647
cjihrig
reviewed
Apr 17, 2026
overbalance
approved these changes
Apr 22, 2026
Contributor
overbalance
left a comment
There was a problem hiding this comment.
nit: add units to the end of the vars (if that is the convention in other files): _MS
Contributor
Author
|
done |
pichlermarc
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_maxDuration * 1000and_inactivityTimeout * 1000can overflow if the config value is large (max safe setTimeout delay is 2147483647, ~24.8 days)If elapsed time exceeds the max duration possible, setTimeout treats that as 1, firing the reset almost immediately
This PR adds a limit to those values.