Skip to content

fix(cli): update to latest cli #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@ cache:
yarn: true

env:
# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.8
- EMBER_TRY_SCENARIO=ember-lts-2.12
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary
- EMBER_TRY_SCENARIO=ember-default
global:
# See https://git.io/vdao3 for details.
- JOBS=1
matrix:
# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.8
- EMBER_TRY_SCENARIO=ember-lts-2.12
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary
- EMBER_TRY_SCENARIO=ember-default

matrix:
fast_finish: true
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ This will automatically install the `ember-cli-sass` NPM dependency and create a
ember install ember-font-awesome
```

## deploy
## Deploy

Deploy the demo app:

```sh
ember deploy production
git push upstream gh-pages
```


Expand Down
3 changes: 0 additions & 3 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
module.exports = function(defaults) {
let app = new EmberAddon(defaults, {
// Add options here
babel: {
plugins: ['transform-decorators-legacy']
}
});

/*
Expand Down
25 changes: 12 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,44 +38,43 @@
"dependencies": {
"babel-eslint": "^7.2.3",
"broccoli-funnel": "^1.2.0",
"ember-cli-babel": "^6.3.0",
"ember-cli-babel": "^6.6.0",
"ember-cli-htmlbars": "^2.0.1",
"ember-decorators": "^1.2.1"
"ember-decorators": "^1.3.0"
},
"devDependencies": {
"@commitlint/cli": "^3.1.2",
"@commitlint/config-angular": "3.1.1",
"babel-plugin-transform-decorators-legacy": "^1.3.4",
"broccoli-asset-rev": "^2.4.5",
"bulma": "^0.5.0",
"code-highlight-linenums": "^0.2.1",
"commitizen": "^2.9.6",
"cz-customizable": "^5.0.0",
"ember-ajax": "^3.0.0",
"ember-cli": "~2.14.2",
"ember-cli": "~2.16.2",
"ember-cli-app-version": "^3.1.0",
"ember-cli-content-security-policy": "^0.6.0",
"ember-cli-dependency-checker": "^1.3.0",
"ember-cli-dependency-checker": "^2.0.0",
"ember-cli-deploy": "^1.0.1",
"ember-cli-deploy-build": "^1.1.0",
"ember-cli-deploy-build": "^1.1.1",
"ember-cli-deploy-git": "^1.3.0",
"ember-cli-eslint": "^3.0.0",
"ember-cli-htmlbars-inline-precompile": "^0.4.3",
"ember-cli-eslint": "^4.0.0",
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
"ember-cli-inject-live-reload": "^1.4.1",
"ember-cli-qunit": "^4.0.0",
"ember-cli-qunit": "^4.0.1",
"ember-cli-sass": "^6.1.3",
"ember-cli-shims": "^1.1.0",
"ember-cli-sri": "^2.1.0",
"ember-cli-uglify": "^1.2.0",
"ember-cli-uglify": "^2.0.0",
"ember-composable-helpers": "~2.0.0",
"ember-disable-prototype-extensions": "^1.1.2",
"ember-export-application-global": "^2.0.0",
"ember-load-initializers": "^1.0.0",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-native-dom-helpers": "^0.5.2",
"ember-native-dom-helpers": "^0.5.4",
"ember-resolver": "^4.0.0",
"ember-source": "~2.14.1",
"ember-themed-syntax": "^0.1.1",
"ember-source": "~2.16.0",
"ember-themed-syntax": "^0.1.2",
"highlightjs": "^9.10.0",
"hljs-themes": "^1.0.0",
"husky": "^0.14.3",
Expand Down
4 changes: 2 additions & 2 deletions tests/dummy/app/app.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import Ember from 'ember';
import Application from '@ember/application';
import Resolver from './resolver';
import loadInitializers from 'ember-load-initializers';
import config from './config/environment';

const App = Ember.Application.extend({
const App = Application.extend({
modulePrefix: config.modulePrefix,
podModulePrefix: config.podModulePrefix,
Resolver
Expand Down
4 changes: 2 additions & 2 deletions tests/dummy/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

{{content-for "head"}}

<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link rel="stylesheet" href="{{rootURL}}assets/dummy.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css">

{{content-for "head-footer"}}
Expand Down
6 changes: 1 addition & 5 deletions tests/dummy/app/router.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import Ember from 'ember';
import EmberRouter from '@ember/routing/router';
import config from './config/environment';

const {
Router: EmberRouter
} = Ember;

const Router = EmberRouter.extend({
location: config.locationType,
rootURL: config.rootURL
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ module.exports = function(environment) {
}

if (environment === 'production') {
// here you can enable a production-specific feature
ENV.rootURL = '/ember-bulma';
ENV.locationType = 'hash';
}
Expand Down
6 changes: 1 addition & 5 deletions tests/helpers/destroy-app.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
import Ember from 'ember';

const {
run
} = Ember;
import { run } from '@ember/runloop';

export default function destroyApp(application) {
run(application, 'destroy');
Expand Down
4 changes: 1 addition & 3 deletions tests/helpers/module-for-acceptance.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { module } from 'qunit';
import Ember from 'ember';
import { resolve } from 'rsvp';
import startApp from '../helpers/start-app';
import destroyApp from '../helpers/destroy-app';

const { RSVP: { resolve } } = Ember;

export default function(name, options = {}) {
module(name, {
beforeEach() {
Expand Down
9 changes: 5 additions & 4 deletions tests/helpers/start-app.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import Ember from 'ember';
import Application from '../../app';
import config from '../../config/environment';
import { merge } from '@ember/polyfills';
import { run } from '@ember/runloop';

export default function startApp(attrs) {
let attributes = Ember.merge({}, config.APP);
attributes = Ember.merge(attributes, attrs); // use defaults, but you can override;
let attributes = merge({}, config.APP);
attributes = merge(attributes, attrs); // use defaults, but you can override;

return Ember.run(() => {
return run(() => {
let application = Application.create(attributes);
application.setupForTesting();
application.injectTestHelpers();
Expand Down
Loading