fix(Azure): support azure model.list #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iBotPeaches merged 1 commit into main from models-list

Jun 12, 2025

Collaborator

iBotPeaches commented Jun 11, 2025

What:

Bug Fix
New Feature

Description:

Adds support for Azure model listing, which uses created_at and removes owned_by.

Related:

fixes: #598


          fix(Azure): support azure model.list

f853b5d

Collaborator Author

iBotPeaches commented Jun 11, 2025

Torn on something here. created_at is specific to a few other providers. I think adding the ?? fallback to non-standard fields is nice, but our typing says that field doesn't exist and thus fails.

In this PR I added it as an optional field to keep typing happy, but I think I might prefer just suppressing the stan warning.

iBotPeaches added this to the v0.13.1 milestone

iBotPeaches merged commit 7e20d19 into main

24 checks passed

iBotPeaches deleted the models-list branch

June 12, 2025 19:31

trandbert37 pushed a commit to trandbert37/openai-php-client that referenced this pull request


          fix(Azure): support azure model.list (openai-php#599)

4d70ddd

iBotPeaches added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug