fix(images.edit): update size type annotation to match documentation
#2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
thanks for the PR! sorry for the delayed review, looks like this has since been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the type annotation of the
sizeparameter in theimages.editmethod to match the official documentation.Currently, the annotation is missing the valid options "1536x1024", "1024x1536", and "auto". As a result, IDEs and type checkers incorrectly flag valid resolutions as errors, causing unnecessary developer pain and triggering existential crises for perfectionists everywhere. 😅
This fix only affects type annotations and does not change runtime behavior.