libcontainer: devices: fix mips builds #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that MIPS uses uint32 in the device number returned by stat(2), so explicitly wrap everything to make the compiler happy. I really wish that Go had C-like numeric type promotion. Signed-off-by: Aleksa Sarai <[email protected]>
Contributor
|
Excellent, thanks. |
Contributor
|
LGTM. This is the same as https://github.com/opencontainers/runc/pull/1769/files |
Member
|
LGTM |
chenx97
added a commit
to chenx97/runc
that referenced
this pull request
Apr 10, 2025
Similar to opencontainers#1824, we need to explicitly convert the device number to uint64 for mips. Signed-off-by: Henry Chen <[email protected]>
chenx97
added a commit
to chenx97/runc
that referenced
this pull request
Apr 10, 2025
Similar to opencontainers#1824, we need to convert the device number to uint64 for mips. Signed-off-by: Henry Chen <[email protected]>
MingcongBai
pushed a commit
to AOSC-Tracking/runc
that referenced
this pull request
Apr 10, 2025
Similar to opencontainers#1824, we need to convert the device number to uint64 for mips. Signed-off-by: Henry Chen <[email protected]>
prcups
pushed a commit
to AOSC-Tracking/runc
that referenced
this pull request
Sep 15, 2025
Similar to opencontainers#1824, we need to convert the device number to uint64 for mips. Signed-off-by: Henry Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that MIPS uses uint32 in the device number returned by
stat(2), so explicitly wrap everything to make the compiler happy. I
really wish that Go had C-like numeric type promotion.
Fixes #1823
Signed-off-by: Aleksa Sarai [email protected]